Minor patches to push upstream

[Tomasz Wasilczyk]

Hello,

I have two changes I made to libftdi fork I'm using internally in my
project. It's nothing huge, but still worth sharing and definitely easier
for me if merged upstream. Please take a look at the attached patches.

libftdi-constargs.patch fixes warnings when I try to pass `const char*`
to ftdi_eeprom_initdefaults.
libftdi-nologspam.patch removes a printf that spams stderr when trying to
flash FT232H eeprom.

Thanks for supporting this library,
Tomasz Wasilczyk


--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+***@developer.intra2net.com

[Tomasz Wasilczyk]

Hello again,

I have some more patches to push upstream, this time they might be more
worthy merging.

0001 & 0002 are the same patches as sent previously, just slightly
reformatted.

0003 fixes a bug when reading USB devices with unset serial number.

0004 & 0005 fix inconsistency against what official FT_Prog tool writes to
EEPROM.

Please take a look and hopefully get them included in the next release.

Thanks,
Tomasz Wasilczyk

Post by Tomasz Wasilczyk
Hello,
I have two changes I made to libftdi fork I'm using internally in my
project. It's nothing huge, but still worth sharing and definitely easier
for me if merged upstream. Please take a look at the attached patches.
libftdi-constargs.patch fixes warnings when I try to pass `const char*`
to ftdi_eeprom_initdefaults.
libftdi-nologspam.patch removes a printf that spams stderr when trying to
flash FT232H eeprom.
Thanks for supporting this library,
Tomasz Wasilczyk

--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+***@developer.intra2net.com

[Thomas Jarosch]

Hi Tomasz,

Post by Tomasz Wasilczyk
I have some more patches to push upstream, this time they might be more
worthy merging.
0001 & 0002 are the same patches as sent previously, just slightly
reformatted.
0003 fixes a bug when reading USB devices with unset serial number.
0004 & 0005 fix inconsistency against what official FT_Prog tool writes to
EEPROM.
Please take a look and hopefully get them included in the next release.

sorry for taking so long, we had a demanding crunch period at work
that lasted a lot longer than usual.

All five patches look good and were applied, thanks!
I've also added you to AUTHORS :)

It took me a bit to verify the change like "if (desc.iManufacturer == 0)",
but I found the explanation in the "USB complete" book: A string index is
zero if the particular field is missing. It was kind of obvious from the
change itself, but I wanted to verify we do the correct thing here.

Cheers,
Thomas

--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+***@developer.intra2net.com

[Tomasz Wasilczyk]

Thanks!

I just realized I made one terribly looking "typo": in "Don't
set EEPROM..." eeprom some lines have 5-space indentation. Do you want me
to send a patch fixing the indentation, or you'll just get it aligned on
your end?

Post by Thomas Jarosch
Hi Tomasz,

Post by Tomasz Wasilczyk
I have some more patches to push upstream, this time they might be more
worthy merging.
0001 & 0002 are the same patches as sent previously, just slightly
reformatted.
0003 fixes a bug when reading USB devices with unset serial number.
0004 & 0005 fix inconsistency against what official FT_Prog tool writes

to

Post by Tomasz Wasilczyk
EEPROM.
Please take a look and hopefully get them included in the next release.

sorry for taking so long, we had a demanding crunch period at work
that lasted a lot longer than usual.
All five patches look good and were applied, thanks!
I've also added you to AUTHORS :)
It took me a bit to verify the change like "if (desc.iManufacturer == 0)",
but I found the explanation in the "USB complete" book: A string index is
zero if the particular field is missing. It was kind of obvious from the
change itself, but I wanted to verify we do the correct thing here.
Cheers,
Thomas
--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.

--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+***@developer.intra2net.com

[Thomas Jarosch]

Hi Tomasz,

Post by Tomasz Wasilczyk
Thanks!
I just realized I made one terribly looking "typo": in "Don't set
EEPROM..." eeprom some lines have 5-space indentation. Do you want me to
send a patch fixing the indentation, or you'll just get it aligned on your
end?

fixed, thanks.

Cheers,
Thomas

--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+***@developer.intra2net.com